182

Unix/Linux 网络时间协议版本3 Network Time Protocol Version 3 (NTP) distribution for Unix systems

Replied: Tue, 17 Mar 1998 16:25:27 -0500
Replied: "Marc Brett <[e-mail]> "
Received: from mail.eecis.udel.edu by whimsy.udel.edu id aa22594;
          17 Mar 1998 13:43 EST
Received: by diamond.waii.com id MAA07448; Tue, 17 Mar 1998 12:42:30 -0600 sender [e-mail] for 
Received: from mail.wg.waii.com(137.144.128.17) user <[e-mail]> by diamond.waii.com via smap (3.2)
	id xma007326; Tue, 17 Mar 98 12:40:32 -0600
Received: from merlin.london.waii.com (merlin.london.waii.com [136.250.33.1])
	by mail1.wg.waii.com (8.8.7/8.8.7) with ESMTP id MAA53954;
	Tue, 17 Mar 1998 12:40:22 -0600
Received: from rgs0.london.waii.com (rgs0.london.waii.com [136.250.40.10])
          by merlin.london.waii.com (8.8.4/8.8.4) with SMTP
	  id SAA14728; Tue, 17 Mar 1998 18:40:20 GMT
Received: by rgs0.london.waii.com (951211.SGI.8.6.12.PATCH1502/920502.SGI)
	 id SAA24816; Tue, 17 Mar 1998 18:40:14 GMT
Date: Tue, 17 Mar 1998 18:40:14 GMT
Message-Id: <[e-mail]>
From: Marc Brett <[e-mail]>
To: [e-mail]
Cc: [e-mail], [e-mail], [e-mail], 
    [e-mail]
Subject: (fwd) Fatal bug in xntpd 3-5.92c!?!
Newsgroups: comp.protocols.time.ntp

Harlan,

This is the solution to that bug that I mentioned on Friday the 13th.
It has solved the clock drift problem we were having with xntp3-5.92a
and xntp3-5.92c on all of our platforms.

It's probably worth a new release ASAP.

Best regards,

Marc


-- forwarded message --
Path: diamond.waii.com!uunet!in2.uu.net!newsfeed.internetmci.com!204.59.152.222!news-peer.gip.net!news-raspail.gip.net!news.gsl.net!gip.net!newscore.univie.ac.at!193.171.255.21.MISMATCH!newsfeed01.univie.ac.at!01-newsfeed.univie.ac.at!news.apanet.at!news.ooe.gv.at!rzsrv00.ooe.gv.at
From: Klaus Kusche <[e-mail]>
Newsgroups: comp.protocols.time.ntp
Subject: Fatal bug in xntpd 3-5.92c!?!
Date: Tue, 17 Mar 1998 16:00:52 +0100
Organization: Government of Upper Austria, Computing Centre
Lines: 51
Message-ID: <[e-mail]>
NNTP-Posting-Host: news.ooe.gv.at
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Mailer: Mozilla 4.04 [en] (X11; I; AIX 4.1)
Xref: diamond.waii.com comp.protocols.time.ntp:4481

When looking into my xntpd problems under AIX,
I found a piece of code (which was changed between
3-5.92 and 3-5.92c!) which looks wrong to me in 3-5.92c:
Braces are missing around the body of an "if".

If I understand things correctly, this bug
causes xntpd not to adjust the local clock any more
as soon as it has sync'ed to any peer!!!

Below is the diff between the original 3-5.92c file
and the file with the braces I inserted.

*** ntp_loopfilter.c.sav        Tue Mar 17 14:57:00 1998
--- ntp_loopfilter.c    Tue Mar 17 14:58:02 1998
***************
*** 586,592 ****
         */
        if (sys_peer) {
                if (sys_peer->refclktype == REFCLK_LOCALCLOCK &&
!                   sys_peer->flags & FLAG_PREFER)
                         /* I think that sys_clock_offset might be
jammed
                          * to exactly zero now.  It might have had a
                          * small residual before things switched to the
--- 586,592 ----
         */
        if (sys_peer) {
                if (sys_peer->refclktype == REFCLK_LOCALCLOCK &&
!                   sys_peer->flags & FLAG_PREFER) {
                         /* I think that sys_clock_offset might be
jammed
                          * to exactly zero now.  It might have had a
                          * small residual before things switched to the
***************
*** 595,600 ****
--- 595,601 ----
                          * when the external control jumped the time */
                        L_CLR(&sys_clock_offset);
                        return;
+               }
        }
        L_CLR(&offset);
        L_ADDF(&offset, adjustment);

-- 
DI. Dr. Klaus Kusche
Oberoesterreichische Landesregierung / Government of Upper Austria
Rechenzentrum / Computing Centre
Smail: Kaerntnerstrasse 16, A-4020 Linz, Austria (Europe)
Phone: [phone] - 3394   Fax: [phone] - 3198
Email: [e-mail]
-- end of forwarded message --

-- 
Marc Brett  [phone]            Western Geophysical
[e-mail]                     455 London Road, Isleworth
FAX: [phone]                   Middlesex TW7 5AB    UK