findnonshortcircuit.java

来自「一个查找java程序里bug的程序的源代码,该程序本身也是java写的,对提高j」· Java 代码 · 共 113 行

/*
 * FindBugs - Find bugs in Java programs
 * Copyright (C) 2003,2004 University of Maryland
 * 
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 * 
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 * 
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */

package edu.umd.cs.findbugs.detect;

import edu.umd.cs.findbugs.BugInstance;
import edu.umd.cs.findbugs.BugReporter;
import edu.umd.cs.findbugs.BytecodeScanningDetector;
import edu.umd.cs.findbugs.visitclass.Constants2;
import org.apache.bcel.classfile.Method;

public class FindNonShortCircuit extends BytecodeScanningDetector implements Constants2 {

	int stage1 = 0;
	int stage2 = 0;
	int distance = 0;
	//int distance2 = 0;
	int operator;
	private BugReporter bugReporter;

	public FindNonShortCircuit(BugReporter bugReporter) {
		this.bugReporter = bugReporter;
	}

	public void visit(Method obj) {
		stage1 = 0;
		stage2 = 0;
		distance = 1000000;
		//distance2 = 1000000;
	}

	public void sawOpcode(int seen) {
		/* prototype for short-circuit bug */
		distance++;
		switch (seen) {
		case ICONST_1:
			stage1 = 1;
			break;
		case GOTO:
			if (stage1 == 1)
				stage1 = 2;
			else
				stage1 = 0;
			break;
		case ICONST_0:
			if (stage1 == 2) {
				distance = 0;
				// System.out.println("saw 1; goto X; 0");
			}
			stage1 = 0;
		default:
			stage1 = 0;
		}
		switch (seen) {
		case IAND:
		case IOR:
			// System.out.println("Saw IOR or IAND at distance " + distance);

			if (distance < 4) {
				operator = seen;
				//distance2 = distance;
				stage2 = 1;
			} else
				stage2 = 0;
			break;
		case IFEQ:
		case IFNE:
			if (stage2 == 1) {
				// System.out.println("Found nsc");
				bugReporter.reportBug(new BugInstance(this, "NS_NON_SHORT_CIRCUIT",
				        NORMAL_PRIORITY)
				        .addClassAndMethod(this)
				        .addSourceLine(this, getPC()));
			}
			stage2 = 0;
			break;
		case PUTFIELD:
		case PUTSTATIC:
		case IRETURN:
			if (operator == IAND && stage2 == 1) {
				// System.out.println("Found nsc");
				bugReporter.reportBug(new BugInstance(this, "NS_NON_SHORT_CIRCUIT",
				        LOW_PRIORITY)
				        .addClassAndMethod(this)
				        .addSourceLine(this, getPC()));
			}
			stage2 = 0;
			break;
		default:
			stage2 = 0;
			break;
		}


	}
}